From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.4 X-Google-Language: ENGLISH,ASCII-7-bit X-Google-Thread: 103376,16c5d42d1a58946d,start X-Google-Attributes: gid103376,public X-Google-ArrivalTime: 2002-04-25 18:31:59 PST Path: archiver1.google.com!news1.google.com!newsfeed.stanford.edu!logbridge.uoregon.edu!arclight.uoregon.edu!wn14eed!worldnet.att.net!135.173.83.55!bgtnsc05-news.ops.worldnet.att.net.POSTED!not-for-mail Message-ID: <3CC8AE13.5020309@worldnet.att.net> From: Jim Rogers User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.4) Gecko/20011128 Netscape6/6.2.1 X-Accept-Language: en-us MIME-Version: 1.0 Newsgroups: comp.lang.ada Subject: Re: Newbie (code review) References: <3cc87b22$0$10098$6e365a64@newsreader02.highway.telekom.at> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 26 Apr 2002 01:31:58 GMT NNTP-Posting-Host: 12.86.34.140 X-Complaints-To: abuse@worldnet.att.net X-Trace: bgtnsc05-news.ops.worldnet.att.net 1019784718 12.86.34.140 (Fri, 26 Apr 2002 01:31:58 GMT) NNTP-Posting-Date: Fri, 26 Apr 2002 01:31:58 GMT Organization: AT&T Worldnet Xref: archiver1.google.com comp.lang.ada:23126 Date: 2002-04-26T01:31:58+00:00 List-Id: Ok, I see a few small things I would do differently. I would place the declaration of procedure "free" in the list package body, not in the private part of the specification. I also wonder why you have "withed" Ada.Exceptions in main when you are not using anything from that package. Jim Rogers Holger Zwar wrote: > hi ada community, > i'm learning ada (reading j. barnes progr. in ada 2nd ed.) since 2 weeks and > i like it very much (i'm coding c++ and java at work). now i think it's a > good time to get some feedback. i'm playing around with a double-linked list > (i know that there are public good libs and i don't want to reinvent the > wheel ;-) and i think i'm doing right. but i don't won't to make thoose > typical beginner mistakes. so what do you (ada profs) think of my code. what > is bad? what should i avoid? > thanks in advance > holger zwar > > >