From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,INVALID_MSGID autolearn=no autolearn_force=no version=3.4.4 X-Google-Language: ENGLISH,ASCII-7-bit X-Google-Thread: f43e6,9a0ff0bffdf63657 X-Google-Attributes: gidf43e6,public X-Google-Thread: fac41,9a0ff0bffdf63657 X-Google-Attributes: gidfac41,public X-Google-Thread: 1108a1,9a0ff0bffdf63657 X-Google-Attributes: gid1108a1,public X-Google-Thread: 103376,4b06f8f15f01a568 X-Google-Attributes: gid103376,public From: Jay Martin Subject: Re: Software landmines (was: Why C++ is successful) Date: 1998/08/16 Message-ID: <35D758F9.E8BBCBE4@earthlink.net>#1/1 X-Deja-AN: 381777384 Content-Transfer-Encoding: 7bit References: <6qfhri$gs7$1@nnrp1.dejanews.com> <35cb8058.645630787@news.ne.mediaone.net> <902934874.2099.0.nnrp-10.c246a717@news.demon.co.uk> <6r1glm$bvh$1@nnrp1.dejanews.com> Content-Type: text/plain; charset=us-ascii Organization: EarthLink Network, Inc. Mime-Version: 1.0 Newsgroups: comp.lang.eiffel,comp.object,comp.software-eng,comp.lang.ada Date: 1998-08-16T00:00:00+00:00 List-Id: dennison@telepath.com wrote: > > In article , > dewar@merv.cs.nyu.edu (Robert Dewar) wrote: > > Andy said > > > > < > goto in C and Pascal in certain rare cases, but I have always found clearer > > ways to code these cases in Ada. > > >> > > > > The two obvious uses vfor gotos in Ada are > > > > 1) to get a loop "continue" mechanism > > for a simple loop, embedding the rest of the loop code in the body of the if > statement is clearer. For nested loops where you want to "continue" an outer > loop, I can see it. Not that I'd do such a thing. As a "goto-holic" who has > been straight for 10 years, the best bet is abstinence. One day at a time. :-) > > > For example, I find the following perfectly clear: > > > > <> for J in 1 .. N - 1 loop > > if D (J) > D (J + 1) then > > Swap (D(J), D(J + 1)); > > goto Sort; > > end if; > > > > It is a little tricky to program this without the goto and not make it > > less clear. Actuallky many people who try this end up with a different > > algorithm (hint: the above sort is cubic, it is NOT a quadratic bubble sort > :-) > > So the "average" poor maintainer schlep looks at this and thinks "is this > just a continue, or a complete restarting of the loop?" Oh yeah, that's > clear. %-( > > If anyone does something this bizzare, they'd better put copious comments > around it explaining its semantics. Otherwise, its the software equivalent of > a land mine. Its just sitting there waiting for someone to touch it, then > ...BOOM! > > Very good counterexample to your own point. Yup. I'll take my stab at what I think the algorithm is doing. I prefer flags and subroutines to gotos. inline void SwapFirstOutOfOrderElements(T D[], int N, bool& NoOutOfOrderElements) { NoOutOfOrderElements = true; for(int J = 0; J < (N-1); J++) { if (D[J] > D[J+1]) { Swap(D[J], D[J+1]); NoOutOfOrderElements = false; break; }//if// }//for// }//SwapFirstOutOfOrderElements// inline void SomeoneShootMeSort(T D[], int N) { bool NoOutOfOrderElements; do { SwapFirstOutOfOrderElements(D, N, NoOutOfOrderElements); } while (!NoOutOfOrderElements); } Heh, its probably got a bug some where in there and heh, do-while syntax sure sucks. The subroutine name is probably too short, maybe it should be "ScanFromTheFrontOfTheArrayAndSwapTheFirstTwoAdjacentOutOfOrderElements". No wait thats too short.... Maybe we should now go onto exponential time and random "highly probable to be sorted" sorts. Jay