From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,
	REPLYTO_WITHOUT_TO_CC autolearn=no autolearn_force=no version=3.4.4
X-Google-Thread: 103376,587e0e0a16d65b10
X-Google-Attributes: gid103376,domainid0,public,usenet
X-Google-Language: ENGLISH,ASCII-7-bit
Path: 
 g2news2.google.com!news4.google.com!feeder1-2.proxad.net!proxad.net!feeder1-1.proxad.net!ecngs!feeder2.ecngs.de!194.25.134.126.MISMATCH!newsfeed01.sul.t-online.de!t-online.de!newsfeed.arcor.de!newsspool4.arcor-online.net!news.arcor.de.POSTED!not-for-mail
From: "Dmitry A. Kazakov" <mailbox@dmitry-kazakov.de>
Subject: Re: Invade wikipedia!
Newsgroups: comp.lang.ada
User-Agent: 40tude_Dialog/2.0.15.1
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Reply-To: mailbox@dmitry-kazakov.de
Organization: cbb software GmbH
References: <l6k0og.o0o.ln@hunter.axlog.fr>
 <go4gqp$5nj$1@octagram.motzarella.org> <gir5og.o5s.ln@hunter.axlog.fr>
 <go66s6$m76$1@octagram.motzarella.org>
 <49a6d506$0$32680$9b4e6d93@newsspool2.arcor-online.net>
 <4a18f335-30f6-4216-8376-0310eb560445@p11g2000yqe.googlegroups.com>
 <49a7ced2$0$31342$9b4e6d93@newsspool4.arcor-online.net>
 <t0tq29ariugm.aftb8vcp4aeg$.dlg@40tude.net>
 <uzlg266ae.fsf@no.email.thanks.invalid>
 <vo7g5a9tdgei$.553b23ltkai3$.dlg@40tude.net>
 <ur61dkf5z.fsf@no.email.thanks.invalid>
Date: Wed, 4 Mar 2009 10:19:32 +0100
Message-ID: <1bn469maobfyz.10yhiqpf5cf3u$.dlg@40tude.net>
NNTP-Posting-Date: 04 Mar 2009 10:19:32 CET
NNTP-Posting-Host: 59379e5b.newsspool3.arcor-online.net
X-Trace: 
 DXC=hBRbW3XK<C2^8FBo0_81f>McF=Q^Z^V384Fo<]lROoR1^YC2XCjHcb9_>;:69m`jG9DNcfSJ;bb[5FCTGGVUmh?4LK[5LiR>kg291HZNlR:B:4
X-Complaints-To: usenet-abuse@arcor.de
Xref: g2news2.google.com comp.lang.ada:4894
Date: 2009-03-04T10:19:32+01:00
List-Id: <comp.lang.ada>

On Wed, 04 Mar 2009 05:52:56 GMT, Anders Wirzenius wrote:

> "Dmitry A. Kazakov" <mailbox@dmitry-kazakov.de> writes:
> 
>> On Tue, 03 Mar 2009 14:16:09 GMT, Anders Wirzenius wrote:
>>
>>> "Dmitry A. Kazakov" <mailbox@dmitry-kazakov.de> writes:
>>> 
>>>>    procedure Insertion_Sort (A: in out Mug_List) is
>>>>    begin
>>>>       for I in A'First + 1..A'Last loop
>>>>          declare
>>>>             Value : constant Mug := A (I);
>>>>             J     : Mug_Number   := I - 1;
>>>>          begin
>>>>             while A (J) > Value loop
>>>>                A (J + 1) := A (J);
>>>>                exit when J = A'First;
>>>>                J := J - 1;
>>>>             end loop;
>>>>             A (J) := Value;
>>>               ^^^^^
>>> How  about    A (J+1) := Value;
>>
>> J+1 is always greater than A'First. Consider sorting (2, 1). 
>>
>>>>          end;
>>>>       end loop;
>>>>    end Insertion_Sort;
> 
> Consider sorting (1,2). Then A (J) < Value and the procedure
> jumps directly to A (J) := Value.

Yes, the inner loop should start at I: 

   while J > A'First and then A (J - 1) > Value loop
      A (J) := A (J - 1); 
      J := J - 1;
   end loop;
   A (J) := Value;

> How about 
> 
>    procedure Insertion_Sort (A: in out Mug_List) is
>    begin
>       for I in A'First+1 .. A'Last loop
>          declare
>             Value : constant Mug := A (I);
>             J     : Mug_Number   := I;
>          begin
>             loop
>                exit when Value >= A (Mug_Number'Pred (J));
>                A (J) := A (Mug_Number'Pred (J));
>                J := Mug_Number'Pred (J);
>                exit when J = A'First;
>             end loop;
>             A (J) := Value;
>          end;
>       end loop;
>    end Insertion_Sort;

-- 
Regards,
Dmitry A. Kazakov
http://www.dmitry-kazakov.de