From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,FORGED_HOTMAIL_RCVD2,
	FREEMAIL_FROM autolearn=no autolearn_force=no version=3.4.4
X-Google-Thread: 103376,f93747e1bf7a65bb
X-Google-NewGroupId: yes
X-Google-Attributes: gida07f3367d7,domainid0,public,usenet
X-Google-Language: ENGLISH,ASCII
Received: by 10.68.224.230 with SMTP id rf6mr3466722pbc.4.1330429849313;
        Tue, 28 Feb 2012 03:50:49 -0800 (PST)
Path: 
 h9ni18803pbe.0!nntp.google.com!news1.google.com!postnews.google.com!v2g2000vbx.googlegroups.com!not-for-mail
From: adacrypt <austin.obyrne@hotmail.com>
Newsgroups: comp.lang.ada
Subject: Re: Banging the Ada Drum.
Date: Tue, 28 Feb 2012 03:49:12 -0800 (PST)
Organization: http://groups.google.com
Message-ID: <02446aed-cb74-42f2-9f0f-9ed6b9535e8b@v2g2000vbx.googlegroups.com>
References: 
 <967bd137-f854-47e1-9d31-e9236c1c0d00@z31g2000vbt.googlegroups.com>
 <83178b55-da15-421a-9747-451db4e495c0@cj6g2000vbb.googlegroups.com>
NNTP-Posting-Host: 86.171.157.65
Mime-Version: 1.0
X-Trace: posting.google.com 1330429849 30705 127.0.0.1 (28 Feb 2012 11:50:49
 GMT)
X-Complaints-To: groups-abuse@google.com
NNTP-Posting-Date: Tue, 28 Feb 2012 11:50:49 +0000 (UTC)
Complaints-To: groups-abuse@google.com
Injection-Info: v2g2000vbx.googlegroups.com; posting-host=86.171.157.65;
 posting-account=pmkN8QoAAAAtIhXRUfydb0SCISnwaeyg
User-Agent: G2/1.0
X-Google-Web-Client: true
X-Google-Header-Order: ARLUEHNKC
X-HTTP-UserAgent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1;
 Trident/4.0; GTB7.3; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR
 3.0.04506.30; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729),gzip(gfe)
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Date: 2012-02-28T03:49:12-08:00
List-Id: <comp.lang.ada>

On Feb 28, 10:49=A0am, Martin <mar...@thedowies.com> wrote:
> On Feb 28, 9:39=A0am, adacrypt <austin.oby...@hotmail.com> wrote:
> [snip]
>
> =A0 FOR I in 30 ..1030 LOOP
> =A0 =A0 A(I) :=3D Alices_Digital_Signature.GetUnits(Numin =3D> I);
> =A0 =A0 B(I) :=3D Alices_Digital_Signature.GetUnits(Numin =3D> I);
> =A0 END LOOP;
>
> Don't explicitly re-use the array limits in loops, prefer:
>
> =A0 =A0for I in A'Range loop
> =A0 =A0 =A0 A (I) :=3D ...
>
> Now the compiler may not inject checks on "A (I)" as it knows that the
> range of "I" is derived directly from "A".
>
> Why have different types for A and B - they are both just arrays of
> Integer with the same index. If you really want to make them
> different, you could do:
>
> =A0 =A0type Index is range 30 .. 1_030;
> =A0 =A0type A_Array_Type is array (Index) of Integer;
> =A0 =A0type B_Array_Type is new A_Array_Type;
>
> =A0 =A0A : A_Array_Type;
> =A0 =A0B : B_Array_Type;
>
> BTW, are you assuming Integer is 32-bits? Because it doesn't have to
> be...it could be as small as 16 bits or larger than 32.
>
> -- Martin

Martin,

May I explain that I am  a retired Ship's Engineer in my late
seventies - I am taking your points on board very self-consciously and
normally would leap at the improvements you suggest - in fact could I
ask you to continue and I will build these improvements into my
existing work.

If I was younger I would have a far more ambitious outlook in
improving my Ada - please keep on pointing out improvements that I can
make.

Also,

Would you please consider rewriting this entire software in your
version of it and I will post that up on my website under yor name or
even your own website with a link from mine.

Thanks again.

- adacrypt